This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

DisableContainerLinuxAutomaticUpdates does not seem to be implemented properly. #1841

Closed

andersosthus opened this issue Apr 29, 2020 · 0 comments · Fixed by #1847

andersosthus commented Apr 29, 2020

In Cluster.go, DisableContainerLinuxAutomaticUpdates is defined as a string:
https://github.com/kubernetes-incubator/kube-aws/blob/c59afae6244e8bd3093b5f89b7e220da0320ed84/pkg/api/cluster.go#L468

But in the templates, it is being evaluated as a boolean:
https://github.com/kubernetes-incubator/kube-aws/blob/c59afae6244e8bd3093b5f89b7e220da0320ed84/builtin/files/userdata/cloud-config-worker#L44
https://github.com/kubernetes-incubator/kube-aws/blob/c0c702ca8891b58de24a3d71807a67dc4277e12b/builtin/files/userdata/cloud-config-etcd#L44
https://github.com/kubernetes-incubator/kube-aws/blob/c59afae6244e8bd3093b5f89b7e220da0320ed84/builtin/files/userdata/cloud-config-controller#L42

I guess it should be a boolean in cluster.go

jorge07 mentioned this issue

[v0.16.0] Fix DisableContainerLinuxAutomaticUpdates data type #1847

Merged

dominicgunn closed this as completed in #1847

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.