Skip to content
This repository has been archived by the owner on Apr 17, 2019. It is now read-only.

Make rescheduler work with Kubernetes 1.6 #2382

Closed
davidopp opened this issue Feb 14, 2017 · 17 comments · Fixed by #2474
Closed

Make rescheduler work with Kubernetes 1.6 #2382

davidopp opened this issue Feb 14, 2017 · 17 comments · Fixed by #2474

Comments

@davidopp
Copy link
Contributor

Taints are being moved from annotation to field of Node, and tolerations are being moved from annotation to field of PodSpec. See kubernetes/kubernetes#25320 and kubernetes/kubernetes#38957

There's no 1.6 milestone in this repo, but it is needed for 1.6.

@davidopp
Copy link
Contributor Author

Also, write release notes for any special considerations when upgrading to 1.6.

@davidopp
Copy link
Contributor Author

cc/ @fgrzadkowski

@kevin-wangzefeng
Copy link

/cc @kubernetes/huawei

@davidopp
Copy link
Contributor Author

#38957 has merged, so HEAD now has the new behavior (taint/toleration annotations are ignored by scheduler, and now scheduler pays attention to taint/toleration fields).

Code freeze is getting close...

@piosz
Copy link
Contributor

piosz commented Feb 25, 2017

This requires #2381 to be fixed first, because Rescheduler reuse a lot of logic from CA and godeps are organized in the way that Rescheduler needs to use exactly the same Kubernetes version that CA. Since the version in CA hasn't been bumped yet it's not possible to bump it independently in Rescheduler.

cc @mwielgus

@davidopp
Copy link
Contributor Author

davidopp commented Mar 4, 2017

cc/ @kubernetes/release-team

@k82cn
Copy link

k82cn commented Mar 12, 2017

@piosz , seems rescheduler still dependent on k8s upstream, why not client-go?

@davidopp
Copy link
Contributor Author

I'm also interested more generally in how close this is to being done for 1.6.
#2381 (comment) is from 8 days ago. I realize we don't have an official code freeze for anything outside of kubernetes/kubernetes but I think this is getting very down to the wire.

@k82cn
Copy link

k82cn commented Mar 12, 2017

@piosz , I can contribute this if the work is not started :).

@k82cn
Copy link

k82cn commented Mar 13, 2017

/assign @k82cn

Also assign to myself, I'm going to build a PR based on client-go; if any comments, please let me know.

@piosz
Copy link
Contributor

piosz commented Mar 13, 2017

I'll do it by tomorrow. @k82cn if you want you can try to bump Kubernetes deps there but it's hard;)

@k82cn
Copy link

k82cn commented Mar 14, 2017

sure, let me try :).

@marun
Copy link

marun commented Mar 14, 2017

@piosz Any update?

@piosz
Copy link
Contributor

piosz commented Mar 14, 2017

I'll send a PR hopefully today.

@ethernetdan
Copy link

@piosz this issue is preventing the release of v1.6.0-rc.1. If not today, could you provide a timeframe for completion?

@piosz
Copy link
Contributor

piosz commented Mar 14, 2017

@ethernetdan huge apologies for the delay. I'll try do it today but I'm in CET timezone. In the worst case it will be done tomorrow.

@ethernetdan
Copy link

@piosz thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants