Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e tests for external health monitor agent #35

Closed
xing-yang opened this issue Sep 10, 2020 · 11 comments
Closed

Add e2e tests for external health monitor agent #35

xing-yang opened this issue Sep 10, 2020 · 11 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@xing-yang
Copy link
Contributor

No description provided.

@NickrenREN
Copy link
Contributor

Anyone who is interested in this ?

@NickrenREN NickrenREN added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Sep 11, 2020
@irbekrm
Copy link

irbekrm commented Sep 14, 2020

Hi! I would be interested in working on this issue.

@NickrenREN
Copy link
Contributor

@irbekrm Thanks a lot

@NickrenREN
Copy link
Contributor

/assign @irbekrm

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 13, 2020
@irbekrm
Copy link

irbekrm commented Dec 13, 2020

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 13, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 13, 2021
@xing-yang
Copy link
Contributor Author

xing-yang commented Mar 17, 2021

See my comment on #34. It is not reliable for an e2e test to depend on whether an event is recorded or not. So we don't have a good way of writing e2e test for this feature yet.

@irbekrm
Copy link

irbekrm commented Mar 17, 2021

Thanks, that makes sense. I will unassign myself now, in case there is a good way sometime later, so someone else can pick this up 😄

/unassign

@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 16, 2021
@xing-yang
Copy link
Contributor Author

Closing this as we are not adding e2e tests for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

5 participants