Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CVE in jsonpath-plus dep #1926

Closed
timd73 opened this issue Oct 13, 2024 · 7 comments
Closed

Fix CVE in jsonpath-plus dep #1926

timd73 opened this issue Oct 13, 2024 · 7 comments

Comments

@timd73
Copy link

timd73 commented Oct 13, 2024

Describe the bug
The jsonpath-plus dependency contains a critical CVE:
CVE-2024-21534

It is fixed (as least as far as "Snyk" scans are concerned) in 10.0.0

The request is to update the dependency in @kubernetes/client-node

Client Version
0.22.0 (and earlier)

Environment (please complete the following information):

  • NodeJS client
@cjihrig
Copy link
Contributor

cjihrig commented Oct 13, 2024

The dependency is updated on the master branch in #1916, and on the release-1.x branch in #1914.

It looks like a release for the 0.x line is underway based on #1920.

@mstruebing
Copy link
Member

mstruebing commented Oct 13, 2024

@brendanburns I've tried to run the release but the workflow isn't successful.
I suspect an outdated authentication token or similar. Running it from my local machine, where I definitely do not have access rights to the package results in the exact same error message.

The error message is:

npm error 404 Not Found - PUT https://registry.npmjs.org/@kubernetes%2fclient-node - Not found                                                              npm error 404  '@kubernetes/client-node@0.22.1' is not in this registry.          

Do you know what's wrong?

Here is the log for the main branch: https://github.com/kubernetes-client/javascript/actions/runs/11317557777/job/31471135586

@brendandburns
Copy link
Contributor

This is due to the npm token expiring, I will generate a new one and re-add it to the gh actions.

@brendandburns
Copy link
Contributor

@mstruebing this should now work.

@rlsf
Copy link

rlsf commented Oct 15, 2024

can we get also a release of the 1.x branch?

@timd73
Copy link
Author

timd73 commented Oct 15, 2024

And what's the ETA on the release of the 0.x line?

@mstruebing
Copy link
Member

@brendandburns thanks, npm release worked fine.

I also released 1.0.0-rc7 as the next tag on npm:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants