Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vSphere credentials format that CCM would read #724

Merged
merged 1 commit into from
Oct 30, 2019
Merged

vSphere credentials format that CCM would read #724

merged 1 commit into from
Oct 30, 2019

Conversation

kron4eg
Copy link
Member

@kron4eg kron4eg commented Oct 30, 2019

What this PR does / why we need it:
According to https://vmware.github.io/vsphere-storage-for-kubernetes/documentation/k8s-secret.html
it's possible to configure vSphere CCM to read credentials from the
Secret instead of plan-text /etc/kubernetes/cloud-config

Fixes #613

Added Secret object as a source for vSphere CCM credentials

@kron4eg
vSphere credentials format that CCM would read
e87011a 
According to https://vmware.github.io/vsphere-storage-for-kubernetes/documentation/k8s-secret.html
it's possible to configure vSphere CCM to read credentials from the
Secret instead of plan-text /etc/kubernetes/cloud-config

Signed-off-by: Artiom Diomin <artiom@loodse.com>
@kron4eg kron4eg requested a review from xmudrii October 30, 2019 14:20
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Oct 30, 2019
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 30, 2019
xmudrii
xmudrii approved these changes Oct 30, 2019
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 176c82919d81cbc3954f2705fd084ced45b82549

@kubermatic-bot kubermatic-bot merged commit 407ac62 into kubermatic:master Oct 30, 2019
@kubermatic-bot kubermatic-bot added this to the v0.11 milestone Oct 30, 2019
@kron4eg kron4eg deleted the vsphere-ccm-secret branch November 4, 2019 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

Assignees

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v0.11
Development

Successfully merging this pull request may close these issues.

vSphere: save access credentials in secret
3 participants
@kron4eg @kubermatic-bot @xmudrii