Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow sourcing of csiConfig from the credentials file #1735

Closed
dakraus opened this issue Jan 14, 2022 · 1 comment · Fixed by #1739
Closed

Allow sourcing of csiConfig from the credentials file #1735

dakraus opened this issue Jan 14, 2022 · 1 comment · Fixed by #1739
Assignees
@xmudrii
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/normal Not that urgent, but is important sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management.
Milestone
KubeOne 1.4

Comments

@dakraus
Copy link
Contributor

dakraus commented Jan 14, 2022

What feature would you like to be added?
In PR #641 we implemented the possibility to source the cloudConfig from the credentials file. It would be useful if we could source the csiConfig from the credentials file as well.

What are use cases of the feature?
When you deploy a Kubernetes cluster with KubeOne and external CCM/CSI on vSphere you have to provide the the password of the CSI driver in clear text as outlined in the documentation (or source code). This feature would help us to clearly separate credentials / configuration in the KubeOneCluster manifest.
@dakraus dakraus added kind/feature Categorizes issue or PR as related to a new feature. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. labels Jan 14, 2022
@xmudrii xmudrii added this to the KubeOne 1.4 milestone Jan 14, 2022
@xmudrii xmudrii self-assigned this Jan 14, 2022
@xmudrii xmudrii added the priority/normal Not that urgent, but is important label Jan 14, 2022
@xmudrii xmudrii mentioned this issue Jan 14, 2022
Merged
@dakraus
Copy link
Contributor Author

dakraus commented Jan 17, 2022

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xmudrii xmudrii

Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/normal Not that urgent, but is important sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management.
Projects
None yet
Milestone
KubeOne 1.4
Development

Successfully merging a pull request may close this issue.

Source csiConfig from the credentials file if present kubermatic/kubeone
2 participants
@xmudrii @dakraus