unattended-upgrades
addon only installes package on ubuntu / debian and does not validate if it is actually enabled
#1645
Labels
kind/bug
Categorizes issue or PR as related to a bug.
sig/cluster-management
Denotes a PR or issue as being assigned to SIG Cluster Management.
What happened:
While upgrading a cluster from Kubernetes
1.19
to1.22
I also migrated from KubeOnev1.2
tov1.3
.When doing so I enabled the
unattended-upgrades
addon. When looking into os configuration of the control nodes, I saw thatunattended-upgrades
package was installed, but not enabled:What is the expected behavior:
How to reproduce the issue:
Not really sure to be honest. All the dynamic worker nodes deployed via
machinedeployment
had this setup correctly.Anything else we need to know?
control nodes currently running
Ubuntu 20.04.2 LTS
worker nodes currently running
Ubuntu 20.04.3 LTS
I would simply extend the addon to also check for the existence of the specific file. Possible solution to this:
https://github.com/skuethe/kubeone/blob/1cb4aa996814f2aced734d92d205334fdb5dffc6/addons/unattended-upgrades/apt.yaml#L58-L59
This will only create the file if it does not exist, respecting any possible manual change to that file.
An alternative would be to just overwrite the file and such force it's usage (which you seem to want when enabling this addon).
Asking for some feedback before creating any PR.
Thanks
Information about the environment:
KubeOne version (
kubeone version
): 1.3.2Provider you're deploying cluster on: Hetzner
Operating system you're deploying on: Ubuntu 20.04.2 LTS
The text was updated successfully, but these errors were encountered: