Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addons directory path is required even if using only embedded addons #1496

Closed
xmudrii opened this issue Sep 6, 2021 · 1 comment · Fixed by #1668
Closed

Addons directory path is required even if using only embedded addons #1496

xmudrii opened this issue Sep 6, 2021 · 1 comment · Fixed by #1668
Assignees
@ahmedwaleedmalik
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/bug Categorizes issue or PR as related to a bug. priority/high sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management.
Milestone
KubeOne 1.4

Comments

@xmudrii
Copy link
Member

xmudrii commented Sep 6, 2021

The users are still required to provide the addons directory path and have the directory created, even if using only addons embedded in the KubeOne binary.

For example, having a KubeOneCluster manifest such as this one will produce an error:

apiVersion: kubeone.io/v1beta1
kind: KubeOneCluster
versions:
  kubernetes: 1.21.4
cloudProvider:
  aws: {}
addons:
  enable: true
  addons:
    - name: default-storage-class
@xmudrii xmudrii added kind/bug Categorizes issue or PR as related to a bug. priority/high sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. labels Sep 6, 2021
@xmudrii xmudrii added this to the KubeOne 1.4 milestone Sep 6, 2021
@xmudrii xmudrii pinned this issue Sep 6, 2021
@xmudrii xmudrii mentioned this issue Sep 6, 2021
Merged
@xmudrii xmudrii mentioned this issue Sep 24, 2021
Closed
@xmudrii xmudrii added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Sep 28, 2021
@xmudrii
Copy link
Member Author

xmudrii commented Sep 28, 2021

xref #1539

@ahmedwaleedmalik ahmedwaleedmalik self-assigned this Oct 27, 2021
@ahmedwaleedmalik ahmedwaleedmalik mentioned this issue Dec 6, 2021
Merged
@xmudrii xmudrii unpinned this issue Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ahmedwaleedmalik ahmedwaleedmalik

Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/bug Categorizes issue or PR as related to a bug. priority/high sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management.
Projects
None yet
Milestone
KubeOne 1.4
Development

Successfully merging a pull request may close this issue.

Addon directory path should be optional when using embedded addons
2 participants
@ahmedwaleedmalik @xmudrii