Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace kubeflow-bot with a GitHub App and GitHub Org #577

Closed
jlewi opened this issue Jan 24, 2020 · 4 comments
Closed

Replace kubeflow-bot with a GitHub App and GitHub Org #577

jlewi opened this issue Jan 24, 2020 · 4 comments

Comments

@jlewi
Copy link
Contributor

jlewi commented Jan 24, 2020

Right now we use a user account
https://github.com/kubeflow-bot
as a robot account.

This is really a pain to manage because there is no easy way to make multiple people administrators of this account.

Using a GitHub App is also much better for programmatic modification.

We can easily create GitHub Apps within our existing Kubeflow GitHub org.

GitHub Apps however can't "own" repositories. So when our CI/CD bot opens up PRs to update kubeflow/manifests where should it create those new branches?

Possible options

  1. Use a branch on kubeflow/manifests
  2. Create a new GitHub org "kubeflow-bots" and put forks of any repos needed by bots there.

I think I prefer the second option.

  • Using a fork seems cleaner then polluting kubeflow repos with a bunch of auto created PRs
  • Using separate forks seems like it would require giving the bot less privileges
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the labels:

Label Probability
kind/feature 0.75

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

@jlewi
Copy link
Contributor Author

jlewi commented Jan 24, 2020

I created the GitHub App kubeflow-auto-bot

and gave it pull request access. This is needed for #571

@stale
Copy link

stale bot commented Apr 24, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in one week if no further activity occurs. Thank you for your contributions.

@stale
Copy link

stale bot commented May 1, 2020

This issue has been closed due to inactivity.

@stale stale bot closed this as completed May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant