You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Sep 19, 2022. It is now read-only.
hi,
In the function “ deletePodsAndServices”,we clean the services by delete all the services of pod including the worker pod. it will be better to avoid deleting unexisting worker services.
func (pc *PyTorchController) deletePodsAndServices(job *pyv1.PyTorchJob, pods []*v1.Pod) error {
if len(pods) == 0 {
return nil
}
// Delete nothing when the cleanPodPolicy is None or Running.
if *job.Spec.CleanPodPolicy == common.CleanPodPolicyNone ||
*job.Spec.CleanPodPolicy == common.CleanPodPolicyRunning {
return nil
}
for _, pod := range pods {
if err := pc.PodControl.DeletePod(pod.Namespace, pod.Name, job); err != nil {
return err
}
// Pod and service have the same name, thus the service could be deleted using pod's name.
if err := pc.ServiceControl.DeleteService(pod.Namespace, pod.Name, job); err != nil {
return err
}
}
return nil
}
The text was updated successfully, but these errors were encountered:
hi,
In the function “ deletePodsAndServices”,we clean the services by delete all the services of pod including the worker pod. it will be better to avoid deleting unexisting worker services.
reference:
The text was updated successfully, but these errors were encountered: