From 7b78b78c3da065877816efb4834a46ae44a675f1 Mon Sep 17 00:00:00 2001 From: numerology Date: Thu, 6 Feb 2020 10:26:52 -0800 Subject: [PATCH 1/4] update version --- backend/src/apiserver/config/sample_config.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/backend/src/apiserver/config/sample_config.json b/backend/src/apiserver/config/sample_config.json index dd394cfb678..c6a41951537 100644 --- a/backend/src/apiserver/config/sample_config.json +++ b/backend/src/apiserver/config/sample_config.json @@ -6,7 +6,7 @@ }, { "name": "[Demo] Unified DSL - Taxi Tip Prediction Model Trainer", - "description": "[GCP Permission requirements](https://github.com/kubeflow/pipelines/blob/master/samples/contrib/parameterized_tfx_oss#permission). [source code](https://console.cloud.google.com/mlengine/notebooks/deploy-notebook?q=download_url%3Dhttps%253A%252F%252Fraw.githubusercontent.com%252Fkubeflow%252Fpipelines%252F0.1.40%252Fsamples%252Fcore%252Fparameterized_tfx_oss%252Ftaxi_pipeline_notebook.ipynb). Example pipeline that does classification with model analysis based on a public tax cab BigQuery dataset.", + "description": "[GCP Permission requirements](https://github.com/kubeflow/pipelines/blob/master/samples/contrib/parameterized_tfx_oss#permission). [source code](https://console.cloud.google.com/mlengine/notebooks/deploy-notebook?q=download_url%3Dhttps%253A%252F%252Fraw.githubusercontent.com%252Fkubeflow%252Fpipelines%252Fmaster%252Fsamples%252Fcore%252Fparameterized_tfx_oss%252Ftaxi_pipeline_notebook.ipynb). Example pipeline that does classification with model analysis based on a public tax cab BigQuery dataset.", "file": "/samples/core/parameterized_tfx_oss/parameterized_tfx_oss.py.yaml" }, { From 2d3d1631b4b645d4b4d710c6996b82e34c056947 Mon Sep 17 00:00:00 2001 From: numerology Date: Thu, 6 Feb 2020 10:37:43 -0800 Subject: [PATCH 2/4] update sed --- backend/Dockerfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/backend/Dockerfile b/backend/Dockerfile index 8302856c5bd..e6e4e6fa18d 100644 --- a/backend/Dockerfile +++ b/backend/Dockerfile @@ -66,7 +66,7 @@ COPY --from=compiler /samples/ /samples/ RUN apt-get update && apt-get install -y ca-certificates # Pin sample doc links to the commit that built the backend image -RUN sed -E "s#/(blob|tree)/master/#/\1/${COMMIT_SHA}/#g" -i /config/sample_config.json +RUN sed -E "s#/(blob|tree|%252F)/master/#/\1/${COMMIT_SHA}/#g" -i /config/sample_config.json # Expose apiserver port EXPOSE 8888 From 5dc5f9091fce6771c393c4a2b869b2e96099d55a Mon Sep 17 00:00:00 2001 From: numerology Date: Thu, 6 Feb 2020 10:51:00 -0800 Subject: [PATCH 3/4] update sed --- backend/Dockerfile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/backend/Dockerfile b/backend/Dockerfile index e6e4e6fa18d..8ba646ee339 100644 --- a/backend/Dockerfile +++ b/backend/Dockerfile @@ -66,7 +66,8 @@ COPY --from=compiler /samples/ /samples/ RUN apt-get update && apt-get install -y ca-certificates # Pin sample doc links to the commit that built the backend image -RUN sed -E "s#/(blob|tree|%252F)/master/#/\1/${COMMIT_SHA}/#g" -i /config/sample_config.json +RUN sed -E "s#/(blob|tree)/master/#/\1/${COMMIT_SHA}/#g" -i /config/sample_config.json && \ + sed -E "s/%252Fmaster/%252F${COMMIT_SHA}/#g" -i /config/sample_config.json # Expose apiserver port EXPOSE 8888 From 475b5235ac902984334ceb35e6dc46fb634ce44c Mon Sep 17 00:00:00 2001 From: numerology Date: Thu, 6 Feb 2020 20:18:11 -0800 Subject: [PATCH 4/4] fix typo --- backend/src/apiserver/config/sample_config.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/backend/src/apiserver/config/sample_config.json b/backend/src/apiserver/config/sample_config.json index c6a41951537..e66f4be9c58 100644 --- a/backend/src/apiserver/config/sample_config.json +++ b/backend/src/apiserver/config/sample_config.json @@ -6,7 +6,7 @@ }, { "name": "[Demo] Unified DSL - Taxi Tip Prediction Model Trainer", - "description": "[GCP Permission requirements](https://github.com/kubeflow/pipelines/blob/master/samples/contrib/parameterized_tfx_oss#permission). [source code](https://console.cloud.google.com/mlengine/notebooks/deploy-notebook?q=download_url%3Dhttps%253A%252F%252Fraw.githubusercontent.com%252Fkubeflow%252Fpipelines%252Fmaster%252Fsamples%252Fcore%252Fparameterized_tfx_oss%252Ftaxi_pipeline_notebook.ipynb). Example pipeline that does classification with model analysis based on a public tax cab BigQuery dataset.", + "description": "[GCP Permission requirements](https://github.com/kubeflow/pipelines/blob/master/samples/core/parameterized_tfx_oss#permission). [source code](https://console.cloud.google.com/mlengine/notebooks/deploy-notebook?q=download_url%3Dhttps%253A%252F%252Fraw.githubusercontent.com%252Fkubeflow%252Fpipelines%252Fmaster%252Fsamples%252Fcore%252Fparameterized_tfx_oss%252Ftaxi_pipeline_notebook.ipynb). Example pipeline that does classification with model analysis based on a public tax cab dataset.", "file": "/samples/core/parameterized_tfx_oss/parameterized_tfx_oss.py.yaml" }, {