From 31f928ed79e16b5b8cf40de7c3b2c45723d94577 Mon Sep 17 00:00:00 2001 From: IronPan Date: Sat, 10 Aug 2019 23:54:58 -0700 Subject: [PATCH] Fix test loophole for loading samples during KFP startup For more context see https://github.com/kubeflow/pipelines/pull/1805#issuecomment-520204987 We could remove this fix when ksonnet is deprecated. --- test/deploy-pipeline.sh | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/test/deploy-pipeline.sh b/test/deploy-pipeline.sh index a34d29f0ba3..45063c41c53 100755 --- a/test/deploy-pipeline.sh +++ b/test/deploy-pipeline.sh @@ -47,12 +47,18 @@ cd ${DIR}/${KFAPP} ## Update pipeline component image pushd ks_app +# Delete pipeline component first before applying so we guarantee the pipeline component is new. +ks delete default -c pipeline +sleep 60s + ks param set pipeline apiImage ${GCR_IMAGE_BASE_DIR}/api-server:${GCR_IMAGE_TAG} ks param set pipeline persistenceAgentImage ${GCR_IMAGE_BASE_DIR}/persistenceagent:${GCR_IMAGE_TAG} ks param set pipeline scheduledWorkflowImage ${GCR_IMAGE_BASE_DIR}/scheduledworkflow:${GCR_IMAGE_TAG} ks param set pipeline uiImage ${GCR_IMAGE_BASE_DIR}/frontend:${GCR_IMAGE_TAG} -# Delete pipeline component first before applying so we guarantee the pipeline component is new. -ks delete default -c pipeline -sleep 60s +# Swap the metadata/artifact storage PD to avoid reusing the old data. +# We should remove this hack when we deprecate ksonnet. +# See https://github.com/kubeflow/pipelines/pull/1805#issuecomment-520204987 for context +ks param set pipeline minioPd ${KFAPP}-storage-metadata-store +ks param set pipeline mysqlPd ${KFAPP}-storage-artifact-store ks apply default -c pipeline popd