Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cache): Cache deployer - Using the same kubectl version as the server #4525

Merged
merged 4 commits into from
Sep 30, 2020
Merged

fix(cache): Cache deployer - Using the same kubectl version as the server #4525

merged 4 commits into from
Sep 30, 2020

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Sep 21, 2020

Fixes #4505

@Ark-kun Ark-kun requested a review from Bobgy September 21, 2020 05:24
@google-cla google-cla bot added the cla: yes label Sep 21, 2020
@kubeflow-bot
Copy link

This change is Reviewable

@Bobgy
Copy link
Contributor

Bobgy commented Sep 22, 2020

/retest
/lgtm
/approve
Thanks!
looks like a temporary failure

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Sep 22, 2020 •
edited
Loading

/hold
I'll check the deployer Pod logs to make sure this is working executed correctly.

@k8s-ci-robot k8s-ci-robot removed the lgtm label Sep 30, 2020
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Sep 30, 2020

/hold cancel

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Sep 30, 2020

/retest

@Bobgy
Copy link
Contributor

Bobgy commented Sep 30, 2020

/lgtm
Thanks for the fix!

@Bobgy Bobgy added the cherrypick-approved area OWNER approves to cherry pick this PR to current active release branch label Sep 30, 2020
@rmgogogo
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy, rmgogogo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Bobgy
Copy link
Contributor

Bobgy commented Sep 30, 2020

/retest

@k8s-ci-robot k8s-ci-robot merged commit 58584e1 into kubeflow:master Sep 30, 2020
@Bobgy Bobgy added the cherrypicked cherry picked to release branch `release-x.y` label Oct 10, 2020
Bobgy pushed a commit that referenced this pull request Oct 10, 2020
@Ark-kun @Bobgy
fix(cache): Cache deployer - Using the same kubectl version as the se…
3979519 
…rver (#4525)

* Cache deployer - Using the same kubectl version as the server

Fixes #4505

* Changed the PATH precedence

* Unquoted the jq output

* Fixed the curl options
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
@Ark-kun @Jeffwan
fix(cache): Cache deployer - Using the same kubectl version as the se…
c9b79fd 
…rver (kubeflow#4525)

* Cache deployer - Using the same kubectl version as the server

Fixes kubeflow#4505

* Changed the PATH precedence

* Unquoted the jq output

* Fixed the curl options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bobgy Bobgy Bobgy left review comments

@rmgogogo rmgogogo Awaiting requested review from rmgogogo

@rui5i rui5i Awaiting requested review from rui5i

Assignees

@rmgogogo rmgogogo

@Bobgy Bobgy

Labels
approved area/execution_cache cherrypick-approved area OWNER approves to cherry pick this PR to current active release branch cherrypicked cherry picked to release branch `release-x.y` cla: yes lgtm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cache deployer fails if the cluster signer is not set
5 participants
@Ark-kun @kubeflow-bot @Bobgy @rmgogogo @k8s-ci-robot