SDK - Components - Temporary removed Kubernetes options from ComponentSpec #4230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…options This reduces the schema size and makes the task launcher options more flexible.
|
This change is |
Ark-kun
added
cherrypick-approved
Ark-kun
force-pushed
the
SDK---Components---Removed-KubernetesOptions
branch
from
0940817
to
44e7b73
Compare
|
Thanks @Ark-kun! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bobgy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Bobgy
pushed a commit
that referenced
this pull request
Jul 20, 2020
…tSpec (#4230) * SDK - Components - Replaced Kubernetes options with generic launcher options This reduces the schema size and makes the task launcher options more flexible. * Removed the launcherOptions for now
Jeffwan
pushed a commit
to Jeffwan/pipelines
that referenced
this pull request
Dec 9, 2020
…tSpec (kubeflow#4230) * SDK - Components - Replaced Kubernetes options with generic launcher options This reduces the schema size and makes the task launcher options more flexible. * Removed the launcherOptions for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the schema size and we can replace it with more generic attribute -
launcherOptionsThe
kubernetesOptionswas an ignored field since support for it was not implemented in the KFP component bridge yet.Splitting the "Replaced Kubernetes options with generic launcher options" PR into two:
kubernetesOptionsfield.launcherOptionsmap to replace it.