Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to stop runs #413

Closed
yebrahim opened this issue Nov 29, 2018 · 2 comments
Closed

Ability to stop runs #413

yebrahim opened this issue Nov 29, 2018 · 2 comments

Comments

@yebrahim
Copy link
Contributor

This requires both the backend support work, an API, and a frontend button to call the API.
@Ark-kun has done some work to explore using Argo's activeDeadlineSeconds field. We also need proper messaging to set the user's expectations that this will stop the workflow without ability to resume.

@Ark-kun, if I understand correctly, this will terminate all the workflow's pods too, not just stop scheduling new ones, correct?

@ajayalfred we'll need a spec and messaging around this experience.

@ajayalfred
Copy link
Contributor

Copy. I'll get this to you asap.

@rileyjbauer
Copy link
Contributor

This functionality is available as of #1039.

Note that for Pipelines that start jobs in GCP, such as those using DataProc, the termination of the pipeline results in a best effort attempt to stop running jobs as soon as possible.
For example, I ran this notebook twice:
https://github.com/kubeflow/pipelines/tree/master/components/gcp/dataproc/submit_hive_job
and the first time I terminated it, the hive query was stopped. The second time, I terminated the pipeline (so the UI showed it as terminated), but the hive query completed before the "cancel" command reached it.

This behavior should be documented to avoid surprising users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants