Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK -Python components - Replace the default image with the official python image #4041

Closed
Ark-kun opened this issue Jun 21, 2020 · 2 comments · Fixed by #4054
Closed

SDK -Python components - Replace the default image with the official python image #4041

Ark-kun opened this issue Jun 21, 2020 · 2 comments · Fixed by #4054
Assignees

Comments

@Ark-kun
Copy link
Contributor

Ark-kun commented Jun 21, 2020

The tensorflow default image is big and outdated. It's also framework-specific while we want the SDK to be framework-neutral.

@rmgogogo
Copy link
Contributor

+1, I remember we already have a ticket on it. will close that one and keep this one.

more info: current tfx image is 2G+ in gcr.io and "docker images" shows it's 5G+.

  1. We use other images as Alexey mentioned for simplicity
  2. (TFX) split it for detailed purpose, e.x. in upcoming new design for IR, we only need Driver and a simple publisher which should be small sized. It will be a dedicated image.
  3. (TFX) TFX docker image can be improved, currently it directly packge the bazel built workspace which is too big. It can copy over the built result to a new base. It can save size a lot.

@rmgogogo rmgogogo added the status/triaged Whether the issue has been explicitly triaged label Jun 22, 2020
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jun 22, 2020

It's also trivial for the users to go back to the tensorflow image if they want:

my_op = create_component_from_func(my_func, base_image='tensorflow/tensorflow:1.3.0-py3')

I remember we already have a ticket on it

Cool. Please link it here if you find it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants