Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix format string in get_kfp_package_path #11712

Merged
merged 2 commits into from
Feb 28, 2025

Conversation

mprahl
Copy link
Contributor

@mprahl mprahl commented Feb 28, 2025

Description of your changes:

This also now uses the in repo SDK for "k8s execution tests".

Checklist:

Signed-off-by: mprahl <mprahl@users.noreply.github.com>
@mprahl
Copy link
Contributor Author

mprahl commented Feb 28, 2025

/cc @HumairAK

@google-oss-prow google-oss-prow bot requested a review from HumairAK February 28, 2025 14:17
Signed-off-by: mprahl <mprahl@users.noreply.github.com>
@HumairAK
Copy link
Collaborator

/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@HumairAK
Copy link
Collaborator

/lgtm

@google-oss-prow google-oss-prow bot merged commit 7d8e921 into kubeflow:master Feb 28, 2025
26 checks passed
@mprahl mprahl deleted the fix-tests branch February 28, 2025 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants