Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sdk): Relax kfp-server-api upper bound to include 2.4 #11685

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chensun
Copy link
Member

@chensun chensun commented Feb 28, 2025

Description of your changes:

Checklist:

Signed-off-by: Chen Sun <chensun@users.noreply.github.com>
@chensun chensun force-pushed the kfp-server-api-2-4-0 branch from edf0e22 to 16352e6 Compare February 28, 2025 00:41
@chensun chensun requested a review from HumairAK February 28, 2025 00:41
Copy link
Contributor

@zazulam zazulam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zazulam
Once this PR has been reviewed and has the lgtm label, please ask for approval from chensun. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@HumairAK
Copy link
Collaborator

CI failures seem unrelated

----- LOGS -----
time="2025-02-28T00:56:09.941Z" level=info msg="capturing logs" argo=true
I0228 00:56:09.976980      21 main.go:58] Setting log level to: '1'
I0228 00:56:09.978577      21 cache.go:117] Connecting to cache endpoint 10.96.151.75:8887
  error: subprocess-exited-with-error
  
  × git clone --filter=blob:none --quiet '[https://github.com/{repo_name}.git](https://github.com/%7Brepo_name%7D.git)' /tmp/pip-req-build-rhvdz79g did not run successfully.
  │ exit code: 128
  ╰─> [1 lines of output]
      fatal: repository '[https://github.com/{repo_name}.git/](https://github.com/%7Brepo_name%7D.git/)' not found
      [end of output]
  
  note: This error originates from a subprocess, and is likely not a problem with pip.
error: subprocess-exited-with-error

× git clone --filter=blob:none --quiet '[https://github.com/{repo_name}.git](https://github.com/%7Brepo_name%7D.git)' /tmp/pip-req-build-rhvdz79g did not run successfully.
│ exit code: 128
╰─> See above for output.

note: This error originates from a subprocess, and is likely not a problem with pip.
I0228 00:56:12.026451      21 launcher_v2.go:188] publish success.
I0228 00:56:12.059354      21 client.go:724] Attempting to update DAG state
F0228 00:56:12.082707      21 main.go:50] failed to execute component: exit status 1
time="2025-02-28T00:56:13.943Z" level=info msg="sub-process exited" argo=true error="<nil>"
Error: exit status 1

Errors look related to: https://github.com/kubeflow/pipelines/pull/11683/files

@mprahl can you take a look? may need to pass repo names here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants