From d62659bd1af6ddcce8f4b6f0dad3edee5aca06e0 Mon Sep 17 00:00:00 2001 From: Ilias Katsakioris Date: Tue, 17 Dec 2019 14:24:05 +0200 Subject: [PATCH] Change which part of the hash value we make use of Signed-off-by: Ilias Katsakioris --- sdk/python/kfp/dsl/_pipeline_volume.py | 9 +++------ sdk/python/tests/dsl/pipeline_volume_tests.py | 4 ++-- 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/sdk/python/kfp/dsl/_pipeline_volume.py b/sdk/python/kfp/dsl/_pipeline_volume.py index acc13cc1b5f0..d1df35e4bca4 100644 --- a/sdk/python/kfp/dsl/_pipeline_volume.py +++ b/sdk/python/kfp/dsl/_pipeline_volume.py @@ -76,12 +76,9 @@ def __init__(self, sort_keys=True), "utf-8")).hexdigest() name_prefix = "pvolume-" - # Name must be no more than 63 characters, so we will keep the last - # chars of the hash value - hash_len = 63 - len(name_prefix) - self.name = (name_prefix + hash_value[len(hash_value)-hash_len:] - if len(hash_value) > hash_len - else name_prefix + hash_value) + self.name = (f"{name_prefix}{hash_value}"[:63] + if len(hash_value) > 63 + else f"{name_prefix}{hash_value}") self.dependent_names = [] def after(self, *ops): diff --git a/sdk/python/tests/dsl/pipeline_volume_tests.py b/sdk/python/tests/dsl/pipeline_volume_tests.py index 6885a4587620..aad88b3701ba 100644 --- a/sdk/python/tests/dsl/pipeline_volume_tests.py +++ b/sdk/python/tests/dsl/pipeline_volume_tests.py @@ -70,8 +70,8 @@ def test_omitting_name(self): def my_pipeline(param='foo'): vol1 = PipelineVolume(pvc="foo") vol2 = PipelineVolume(name="provided", pvc="foo") - name1 = ("pvolume-2013e9b95c192eb6a2c7d5a023ebeb51f6a114486e31216e" - "083a563") + name1 = ("pvolume-127ac63cf2013e9b95c192eb6a2c7d5a023ebeb51f6a1144" + "86e3121") name2 = "provided" self.assertEqual(vol1.name, name1) self.assertEqual(vol2.name, name2)