From 9cd220bdd6cb52c75b2d64eb5ab8a325275a123b Mon Sep 17 00:00:00 2001 From: Diogo Real Date: Mon, 10 Feb 2020 10:54:56 -0800 Subject: [PATCH] Address PR comments --- frontend/src/lib/OutputArtifactLoader.ts | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/frontend/src/lib/OutputArtifactLoader.ts b/frontend/src/lib/OutputArtifactLoader.ts index d300bb94484..071d7d4a693 100644 --- a/frontend/src/lib/OutputArtifactLoader.ts +++ b/frontend/src/lib/OutputArtifactLoader.ts @@ -507,7 +507,9 @@ function filterArtifactUrisByType( artifactTypeIds.includes(artifact.getTypeId()), ); - const tfdvArtifactsPaths = matchingArtifacts.map(artifact => artifact.getUri()); // uri not empty + const tfdvArtifactsPaths = matchingArtifacts + .map(artifact => artifact.getUri()) + .filter(uri => uri); // uri not empty return tfdvArtifactsPaths; } @@ -520,7 +522,7 @@ async function buildArtifactViewer(script: string[]): Promise const visualization = await Apis.buildPythonVisualizationConfig(visualizationData); if (!visualization.htmlContent) { // TODO: Improve error message with details. - throw new Error('Failed to build TFDV artifact visualization'); + throw new Error('Failed to build artifact viewer'); } return { htmlContent: visualization.htmlContent,