From 94b0431b53f1880f31d846d3ff181debc440d226 Mon Sep 17 00:00:00 2001 From: IronPan Date: Wed, 30 Oct 2019 11:41:05 -0700 Subject: [PATCH] Pin tensorboard version to 1.13.2 (#2513) * Pin tensorboard version to 1.13.2 Using latest causes various uncertainties due to tensorflow backward incompatibility especially new 2.0. In long term we should allow user specify the tensorboard image version. /assign @numerology cc @jingzhang36 * Update reconciler.go * Update reconciler.go * Update reconciler_test.go * Update reconciler_test.go --- .../src/crd/controller/viewer/reconciler/reconciler.go | 6 ++++-- .../controller/viewer/reconciler/reconciler_test.go | 10 ++++------ 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/backend/src/crd/controller/viewer/reconciler/reconciler.go b/backend/src/crd/controller/viewer/reconciler/reconciler.go index 7b998684b2c..1792f47dd5f 100644 --- a/backend/src/crd/controller/viewer/reconciler/reconciler.go +++ b/backend/src/crd/controller/viewer/reconciler/reconciler.go @@ -165,12 +165,14 @@ func setPodSpecForTensorboard(view *viewerV1beta1.Viewer, s *corev1.PodSpec) { c := &s.Containers[0] c.Name = view.Name + "-pod" - c.Image = "tensorflow/tensorflow" + c.Image = "tensorflow/tensorflow:1.13.2" c.Args = []string{ "tensorboard", fmt.Sprintf("--logdir=%s", view.Spec.TensorboardSpec.LogDir), fmt.Sprintf("--path_prefix=/tensorboard/%s/", view.Name), - "--bind_all", + // This is needed for tf 2.0. We need to optionally add it + // when https://github.com/kubeflow/pipelines/issues/2514 is done + // "--bind_all", } c.Ports = []corev1.ContainerPort{ corev1.ContainerPort{ContainerPort: viewerTargetPort}, diff --git a/backend/src/crd/controller/viewer/reconciler/reconciler_test.go b/backend/src/crd/controller/viewer/reconciler/reconciler_test.go index 469d4a8b321..c6a996eb67d 100644 --- a/backend/src/crd/controller/viewer/reconciler/reconciler_test.go +++ b/backend/src/crd/controller/viewer/reconciler/reconciler_test.go @@ -174,12 +174,11 @@ func TestReconcile_EachViewerCreatesADeployment(t *testing.T) { Spec: corev1.PodSpec{ Containers: []corev1.Container{{ Name: "viewer-123-pod", - Image: "tensorflow/tensorflow", + Image: "tensorflow/tensorflow:1.13.2", Args: []string{ "tensorboard", "--logdir=gs://tensorboard/logdir", - "--path_prefix=/tensorboard/viewer-123/", - "--bind_all"}, + "--path_prefix=/tensorboard/viewer-123/"}, Ports: []corev1.ContainerPort{{ContainerPort: 6006}}, }}}}}}} @@ -272,12 +271,11 @@ func TestReconcile_ViewerUsesSpecifiedVolumeMountsForDeployment(t *testing.T) { Spec: corev1.PodSpec{ Containers: []corev1.Container{{ Name: "viewer-123-pod", - Image: "tensorflow/tensorflow", + Image: "tensorflow/tensorflow:1.13.2", Args: []string{ "tensorboard", "--logdir=gs://tensorboard/logdir", - "--path_prefix=/tensorboard/viewer-123/", - "--bind_all"}, + "--path_prefix=/tensorboard/viewer-123/"}, Ports: []corev1.ContainerPort{{ContainerPort: 6006}}, VolumeMounts: []v1.VolumeMount{ {Name: "/volume-mount-name", MountPath: "/mount/path"},