From 17b55a3002cc8cb553f8b80133a39fa803363e31 Mon Sep 17 00:00:00 2001 From: Helber Belmiro Date: Fri, 6 Sep 2024 16:24:17 -0300 Subject: [PATCH] test: Fixed `kfp-runtime-tests` to run on master branch (#11158) Signed-off-by: hbelmiro Signed-off-by: KevinGrantLee --- sdk/runtime_tests/execute_commands_args_test.py | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/sdk/runtime_tests/execute_commands_args_test.py b/sdk/runtime_tests/execute_commands_args_test.py index 42b7672b32a..f920ef971eb 100644 --- a/sdk/runtime_tests/execute_commands_args_test.py +++ b/sdk/runtime_tests/execute_commands_args_test.py @@ -96,8 +96,6 @@ class RuntimeTestConfig: ) ] -PULL_NUMBER = None - def run_commands_and_args( config: RuntimeTestConfig, @@ -116,16 +114,8 @@ def run_commands_and_args( # so much that it renders the test less valuable, since the # commands/args resemble the true runtime commands/args less well # prefer the less invasive approach of installing from a PR - global PULL_NUMBER - if PULL_NUMBER is None: - if 'PULL_NUMBER' in os.environ: - PULL_NUMBER = os.environ['PULL_NUMBER'] - else: - PULL_NUMBER = input( - "Please provide the PR number for the kubeflow/pipelines PR that contains the changes you'd like to test:" - ) - - kfp_package_path = f'git+https://github.com/kubeflow/pipelines.git@refs/pull/{PULL_NUMBER}/merge#subdirectory=sdk/python' + + kfp_package_path = 'sdk/python' command_and_args = [ re.sub(r"'kfp==(\d+).(\d+).(\d+)(-[a-z]+.\d+)?'", kfp_package_path, cmd) for cmd in command_and_args