-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: clarify python client installation steps #796
docs: clarify python client installation steps #796
Conversation
Signed-off-by: Eric Dobroveanu <edobrove@redhat.com>
Signed-off-by: Eric Dobroveanu <edobrove@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks a lot @Crazyglue and all for 👀
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Al-Pragliola, tarilabs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
When doing a fresh install of the python client for local development, I ran into an issue where dependencies would install, but there would be a bunch of unformatted files in my git working directory. After some checking it appears after a
make install
you need to runmake tidy
to format everything. This is already encapsulated in theMakefile
asall: install tidy
, so all thats actually needed is to just runmake
.This updates the README.md to clarify this point
How Has This Been Tested?
Merge criteria:
DCO
check)If you have UI changes