-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(isvc): switched to the correct annotation in mr svc #772
fix(isvc): switched to the correct annotation in mr svc #772
Conversation
Signed-off-by: Alessio Pragliola <seth.pro@gmail.com>
@Al-Pragliola: GitHub didn't allow me to request PR reviews from the following users: pboyd. Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch @Al-Pragliola !
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pboyd, tarilabs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Fixed a typo that caused the inferenceservice reconciler function to check the wrong annotation in the model registry service
How Has This Been Tested?
local cluster + tests
Merge criteria:
DCO
check)