Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): update path icon alignment, remove Split and revert to TextInputGroup #762

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

jenny-s51
Copy link
Member

Description

Slash for "Path" input should be aligned inside of the input field.

Before:
Screenshot 2025-02-04 at 1 47 27 PM

After:
Screenshot 2025-02-04 at 1 44 58 PM

How Has This Been Tested?

  1. In Model Registry list view, click "Register Model" button.
  2. Scroll down to "Model Location" -> "Object storage"
  3. Verify "Path" field has proper alignment and "/" icon is positioned within the form field.

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com>

add classname to formgroup

add classname to formgroup
Copy link
Contributor

@lucferbux lucferbux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Screenshot 2025-02-10 at 16 00 29

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lucferbux

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 88ac5fb into kubeflow:main Feb 10, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants