Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply MUI theming to Registered Model List View #432

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Apply MUI theming to Registered Model List View #432

wants to merge 1 commit into from
+999 −47

Conversation

jenny-s51
Copy link

@jenny-s51 jenny-s51 commented Sep 26, 2024 •
edited
Loading

Description

Applies theming and styles to MR UI for Registered Models List View.

Before:
Screenshot 2024-09-26 at 9 37 07 AM

After:
Screenshot 2024-09-26 at 9 24 35 AM

How Has This Been Tested?

Visual updates only - tested manually in UI.

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign alexcreasy for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ederign
Copy link
Member

ederign commented Sep 26, 2024

/retest

@ederign
Copy link
Member

ederign commented Sep 26, 2024

/ok-to-test

@ederign
Copy link
Member

ederign commented Sep 26, 2024

@tarilabs can you please fire the workflows here?

@Griffin-Sullivan
Copy link
Contributor

Griffin-Sullivan commented Sep 26, 2024 •
edited
Loading

image
The filter on the registered models page doesn't change the filter label when selecting Owner. Should say "Find by Owner" here.

@Griffin-Sullivan
Copy link
Contributor

@jenny-s51 are we also able to add a little bit of spacing between the filter button and the text in the image above?

Griffin-Sullivan
Griffin-Sullivan reviewed Sep 26, 2024
View reviewed changes
clients/ui/frontend/src/style/MUI-theme.scss Outdated Show resolved Hide resolved
clients/ui/frontend/src/app/pages/modelRegistry/screens/ModelRegistry.tsx
@@ -7,6 +7,7 @@ import { filterLiveModels } from '~/app/utils';
import ModelRegistrySelectorNavigator from './ModelRegistrySelectorNavigator';
import RegisteredModelListView from './RegisteredModels/RegisteredModelListView';
import { modelRegistryUrl } from './routeUtils';
import '~/style/MUI-theme.scss';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might not understand how all of this works, but are we able to just import this at a higher level so we don't need to import in multiple places?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, removed other imports

@jenny-s51
Apply MUI theming to MR UI List View
1541ea4 
Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com>

adjust padding of label for consistency in focused state

fix filter label text, add padding, remove unused imports
jenny-s51
jenny-s51 commented Sep 26, 2024
View reviewed changes
Copy link
Author

@jenny-s51 jenny-s51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reviewing @Griffin-Sullivan !

The filter on the registered models page doesn't change the filter label when selecting Owner. Should say "Find by Owner" here.

Nice catch, fixed this

@jenny-s51 are we also able to add a little bit of spacing between the filter button and the text in the image above?

Yes, added some padding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Griffin-Sullivan Griffin-Sullivan Griffin-Sullivan left review comments

@alexcreasy alexcreasy Awaiting requested review from alexcreasy

@andreyvelich andreyvelich Awaiting requested review from andreyvelich

@ederign ederign Awaiting requested review from ederign

Assignees
No one assigned
Labels
Area/UI ok-to-test size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jenny-s51 @ederign @Griffin-Sullivan