-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds an endpoint to get a registered model by id #339
Adds an endpoint to get a registered model by id #339
Conversation
FYI there's a typo in the commit message. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the changes. Everything is working for me.
Changes seem to work fine, great work here, I subscribe to @Griffin-Sullivan questions, once that's sorted out we can lgtm it! |
11053bf
to
28fed11
Compare
Changes are good to me |
/approve |
/lgtm |
@alexcreasy: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I mean, that's fair that I can't LGTM it myself technically, but Griffen just did :P |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexcreasy just some small changes related to our API design. Another option is to use https://pkg.go.dev/github.com/julienschmidt/httprouter#Router.RedirectTrailingSlash , but we would need to investigate better if there is any side effect of using it.
Also, could you please add the example from the PR in our README?
28fed11
to
65c0cbc
Compare
5434cb6
to
d520713
Compare
@ederign think we should be gtg now |
Signed-off-by: Alex Creasy <alex@creasy.dev>
d520713
to
8e28767
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexcreasy, ederign, Griffin-Sullivan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Adds an endpoint to fetch registered models by id.
How Has This Been Tested?
Test rig setup:
make run PORT=4000 MOCK_K8S_CLIENT=true
Test routine:
curl -i localhost:4000/api/v1/model-registry/model-registry/registered_models/1
curl -i localhost:4000/api/v1/model-registry/model-registry/registered_models/fluglebinder
Merge criteria:
DCO
check)If you have UI changes