Drop logical model mapping tests #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Isabella do Amaral <idoamara@redhat.com>
isinyaaa
force-pushed
the
push-uutmvsmzxvzv
branch
2 times, most recently
from
51fd6d2 to
82d8350
Compare
|
cc: @tarilabs |
tarilabs
reviewed
Aug 29, 2024
Since [1] the Python client doesn't access MLMD directly, instead routing requests through the MR server, there's no need to check for matching implementations. [1]: 9b9be50 "Switch Python client backend to use REST (kubeflow#152)" Signed-off-by: Isabella do Amaral <idoamara@redhat.com>
isinyaaa
force-pushed
the
push-uutmvsmzxvzv
branch
from
82d8350 to
6befa8b
Compare
tarilabs
approved these changes
Aug 29, 2024
There was a problem hiding this comment.
Thank you Isabella, approving per #295 (review) and related discussions.
Also thanks @lampajr for chiming in
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tarilabs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Al-Pragliola
pushed a commit
to Al-Pragliola/model-registry
that referenced
this pull request
Sep 3, 2024
* CONTRIBUTING: Get rid of remote-mlmd recommendations Signed-off-by: Isabella do Amaral <idoamara@redhat.com> * robot: drop logical model mapping tests Since [1] the Python client doesn't access MLMD directly, instead routing requests through the MR server, there's no need to check for matching implementations. [1]: 9b9be50 "Switch Python client backend to use REST (kubeflow#152)" Signed-off-by: Isabella do Amaral <idoamara@redhat.com> --------- Signed-off-by: Isabella do Amaral <idoamara@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: https://issues.redhat.com/browse/RHOAIENG-12015
Follow-up to #295 (review).
Description
How Has This Been Tested?
Merge criteria:
DCOcheck)