Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Py: bump aiohttp to 3.10.1 #251

Merged
merged 3 commits into from
Aug 7, 2024

Conversation

isinyaaa
Copy link
Contributor

@isinyaaa isinyaaa commented Aug 6, 2024

Supersedes: #242
Resolves: https://issues.redhat.com/browse/RHOAIENG-10990

Description

drops deprecated method and removes autogen empty tests preventing RuntimeError.

How Has This Been Tested?

Merge criteria:

  • The commits and have meaningful messages; the author will squash them after approval or will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

dependabot bot and others added 3 commits August 6, 2024 12:13
Bumps [aiohttp](https://github.com/aio-libs/aiohttp) from 3.9.5 to 3.10.1.
- [Release notes](https://github.com/aio-libs/aiohttp/releases)
- [Changelog](https://github.com/aio-libs/aiohttp/blob/master/CHANGES.rst)
- [Commits](aio-libs/aiohttp@v3.9.5...v3.10.1)

---
updated-dependencies:
- dependency-name: aiohttp
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Isabella do Amaral <idoamara@redhat.com>
Signed-off-by: Isabella do Amaral <idoamara@redhat.com>
Copy link
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for incorporating #242 (comment) , and as discussed removing empty tests--we can always revise if we find use for those very small (and currently generated empty) unit tests.

/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tarilabs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 7e39377 into kubeflow:main Aug 7, 2024
14 checks passed
@isinyaaa isinyaaa deleted the push-vvmxoulmtqtz branch August 7, 2024 13:14
dhirajsb added a commit to dhirajsb/model-registry-kfp that referenced this pull request Aug 30, 2024
* chore: Add kind integration test, fixes kubeflow#251

* Remove unused IMG_VERSION env variable in pr build workflow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants