Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubeflow components metrics not merged by istio #2454

Closed
Tracked by #2763
axel7083 opened this issue May 5, 2023 · 2 comments
Closed
Tracked by #2763

kubeflow components metrics not merged by istio #2454

axel7083 opened this issue May 5, 2023 · 2 comments
Labels
help wanted Extra attention is needed lifecycle/stale

Comments

@axel7083
Copy link
Contributor

axel7083 commented May 5, 2023

Description

I am trying to collect all metrics from the different Kubeflow components and particularly the notebook controller using Prometheus.

Environment

The configuration is the one by default.

  • The cluster-local-gateway has the 15020 port open exposing the /metrics and /stats/prometheus1.
  • The istio configmap in the istio-system namespace has enablePrometheusMerge: true.

The annotations are properly overwritten by istio for the notebook-controller-deployment, here is an example:

kubectl get pod -n kubeflow notebook-controller-deployment-... -o jsonpath='{.metadata.annotations}' give

{
    ...
    "prometheus.io/path": "/stats/prometheus",
    "prometheus.io/port": "15020",
    "prometheus.io/scrape": "true",
    "sidecar.istio.io/status": "...."
}

Calling the /stats/prometheus on notebook service will result in the same metrics from the cluster local gateway.

Reproduce

  • Forward notebook-controller-service: kubectl port-forward -n kubeflow svc/notebook-controller-service 8080:8080
  • Forward cluster-local-gateway service: kubectl port-forward -n istio-system svc/cluster-local-gateway 15020:15020

Go on localhost:8080/metrics and compare with localhost:15020/stats/prometheus, they are no corresponding metrics.

Footnotes

  1. Istio documentation

@axel7083 axel7083 changed the title kubeflow components metrics not merged kubeflow components metrics not merged by istio May 5, 2023
@juliusvonkohout juliusvonkohout added the help wanted Extra attention is needed label Jan 11, 2024
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Copy link

This issue has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed lifecycle/stale
Projects
Status: Closed
Development

No branches or pull requests

2 participants