Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postsubmits need to use registry components at commit being tested #96

Closed
jlewi opened this issue Jan 6, 2018 · 1 comment
Closed

Comments

@jlewi
Copy link
Contributor

jlewi commented Jan 6, 2018

In postsubmit tests we need to pull registry components at the commit being tested by prow and not head.

@jlewi
Copy link
Contributor Author

jlewi commented Mar 26, 2018

This is fixed here:
https://github.com/kubeflow/kubeflow/blob/master/testing/test_deploy.py#L142

We automatically replace the package with a symlink to the code that we checked out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant