Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1-click deploy] propagate PD name to ks app via ks param set #2617

Closed
kunmingg opened this issue Mar 4, 2019 · 1 comment · Fixed by #2625
Closed

[1-click deploy] propagate PD name to ks app via ks param set #2617

kunmingg opened this issue Mar 4, 2019 · 1 comment · Fixed by #2625
Labels
area/pipelines priority/p1

Comments

@kunmingg
Copy link
Contributor

kunmingg commented Mar 4, 2019

Current PD name is passed as ks init parameter:
https://github.com/kubeflow/kubeflow/blob/master/bootstrap/cmd/bootstrap/app/ksServer.go#L1299

However, mysqlPd and minioPd can not be used as ks init parameter, as they don't have entry in pipeline prototype

Instead we should pass them by ks param set
@kunmingg
Copy link
Contributor Author

kunmingg commented Mar 4, 2019

@IronPan

@IronPan IronPan mentioned this issue Mar 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/pipelines priority/p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

store non exist parameter differently IronPan/kubeflow
1 participant
@kunmingg