Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] Remove request validation in unit test #619

Closed
gaocegege opened this issue May 31, 2019 · 0 comments · Fixed by #626
Closed

[feature request] Remove request validation in unit test #619

gaocegege opened this issue May 31, 2019 · 0 comments · Fixed by #626
Assignees

Comments

@gaocegege
Copy link
Member

/kind feature

Describe the solution you'd like
[A clear and concise description of what you want to happen.]

checking if we get expected requests is hard in unit tests. We should remove it.

/cc @johnugeorge

/assign

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant