Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controller should allow an empty CPU resource limit #1559

Closed
sravi999 opened this issue Jun 17, 2021 · 2 comments · Fixed by #1564
Closed

Controller should allow an empty CPU resource limit #1559

sravi999 opened this issue Jun 17, 2021 · 2 comments · Fixed by #1564
Assignees
Labels

Comments

@sravi999
Copy link

/kind bug

What steps did you take and what happened:
[A clear and concise description of what the bug is.]
The controller should allow an empty CPU resources limit when the CPU limit is empty.

What did you expect to happen:
If the CPU limit is empty don't set a default value for the CPU.

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Environment:
AWS EKS

  • Kubeflow version (kfctl version): V1.1
  • Minikube version (minikube version):
  • Kubernetes version: (use kubectl version): V1.17
  • OS (e.g. from /etc/os-release):
@sravi999
Copy link
Author

cc: @andreyvelich

@andreyvelich
Copy link
Member

Thank you for creating this @sravi999.
For all resources we can follow the Ephemeral Storage policy to remove them: https://github.com/kubeflow/katib/blob/master/pkg/util/v1beta1/katibconfig/config.go#L291.

/assign @andreyvelich

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants