Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deprecated api apiextensions.k8s.io/v1beta1 #1354

Closed
daftping opened this issue Oct 1, 2020 · 8 comments
Closed

Update deprecated api apiextensions.k8s.io/v1beta1 #1354

daftping opened this issue Oct 1, 2020 · 8 comments

Comments

@daftping
Copy link

daftping commented Oct 1, 2020

/kind bug

What steps did you take and what happened:
[A clear and concise description of what the bug is.]
Update deprecated api group apiextensions.k8s.io/v1beta1 - code.

https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.16.md#deprecations-and-removals
The apiextensions.k8s.io/v1beta1 version of CustomResourceDefinition is deprecated and will no longer be served in v1.19. Use apiextensions.k8s.io/v1 instead. (#79604, @liggitt)

The CustomResourceDefinition API type is promoted to apiextensions.k8s.io/v1 with the following changes:

  • Use of the new default feature in validation schemas is limited to v1
  • spec.scope is no longer defaulted to Namespaced and must be explicitly specified
  • spec.version is removed; use spec.versions instead
  • spec.validation is removed; use spec.versions[*].schema instead
  • spec.subresources is removed; use spec.versions[*].subresources instead
  • spec.additionalPrinterColumns is removed; use spec.versions[*].additionalPrinterColumns instead
  • spec.conversion.webhookClientConfig is moved to spec.conversion.webhook.clientConfig
  • spec.conversion.conversionReviewVersions is moved to spec.conversion.webhook.conversionReviewVersions
  • spec.versions[*].schema.openAPIV3Schema is now required when creating v1 CustomResourceDefinitions
  • spec.preserveUnknownFields: true is disallowed when creating v1 CustomResourceDefinitions; it must be specified within schema definitions as x-kubernetes-preserve-unknown-fields: true
  • In additionalPrinterColumns items, the JSONPath field was renamed to jsonPath (fixes v1: CustomResourceColumnDefinition JSONPath should be serialized as "jsonPath" kubernetes/kubernetes#66531)
    The apiextensions.k8s.io/v1beta1 version of CustomResourceDefinition is deprecated and will no longer be served in v1.19.

What did you expect to happen:

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Environment:

  • Kubeflow version (kfctl version):
  • Minikube version (minikube version):
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the labels:

Label Probability
area/katib 0.90

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

1 similar comment
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the labels:

Label Probability
area/katib 0.90

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

@andreyvelich
Copy link
Member

Thanks for the information @daftping.
@gaocegege @johnugeorge Should we fix it before the 1.2 release?

I am concerned that we use other deprecated APIs. For example, admissionregistration.k8s.io/v1beta1

@gaocegege
Copy link
Member

I think we should have a detailed review for this.

@stale
Copy link

stale bot commented Jan 20, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@andreyvelich
Copy link
Member

/lifecycle frozen

@gaocegege
Copy link
Member

@gaocegege
Copy link
Member

We have some problems with v1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants