Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new permission to Katib UI RBAC to view suggestions #1165

Closed
andreyvelich opened this issue Apr 23, 2020 · 4 comments
Closed

Add new permission to Katib UI RBAC to view suggestions #1165

andreyvelich opened this issue Apr 23, 2020 · 4 comments

Comments

@andreyvelich
Copy link
Member

/kind feature

After this PR: #1162, Katib UI RBAC must have permission to select Suggestion CR: https://github.com/kubeflow/katib/blob/master/manifests/v1alpha3/ui/rbac.yaml#L18.

We should update Kubeflow Katib Manifest with this new permission: https://github.com/kubeflow/manifests/blob/master/katib/katib-controller/base/katib-ui-rbac.yaml#L15, when we switch to the latest Katib images.

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the labels:

Label Probability
feature 0.98

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

@andreyvelich
Copy link
Member Author

This was merged by kubeflow/manifests#1239.

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the labels:

Label Probability
area/katib 0.93

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

1 similar comment
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the labels:

Label Probability
area/katib 0.93

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants