From eca734a4e1ce8e9d031ec9a7051f259aa9602813 Mon Sep 17 00:00:00 2001 From: Ce Gao Date: Wed, 12 Jun 2019 17:23:07 +0800 Subject: [PATCH] fix: Fix test cases Signed-off-by: Ce Gao --- .../experiment/experiment_controller_test.go | 12 ---------- .../v1alpha2/trial/trial_controller_test.go | 24 ------------------- 2 files changed, 36 deletions(-) diff --git a/pkg/controller/v1alpha2/experiment/experiment_controller_test.go b/pkg/controller/v1alpha2/experiment/experiment_controller_test.go index d93891359c9..8b80df041d1 100644 --- a/pkg/controller/v1alpha2/experiment/experiment_controller_test.go +++ b/pkg/controller/v1alpha2/experiment/experiment_controller_test.go @@ -83,12 +83,6 @@ func TestCreateExperiment(t *testing.T) { stopMgr, mgrStopped := StartTestManager(mgr, g) - stopCh := make(chan struct{}) - g.Expect(mgr.GetCache().WaitForCacheSync(stopCh)).To(gomega.BeTrue()) - defer func() { - close(stopCh) - }() - defer func() { close(stopMgr) mgrStopped.Wait() @@ -221,12 +215,6 @@ spec: stopMgr, mgrStopped := StartTestManager(mgr, g) - stopCh := make(chan struct{}) - g.Expect(mgr.GetCache().WaitForCacheSync(stopCh)).To(gomega.BeTrue()) - defer func() { - close(stopCh) - }() - defer func() { close(stopMgr) mgrStopped.Wait() diff --git a/pkg/controller/v1alpha2/trial/trial_controller_test.go b/pkg/controller/v1alpha2/trial/trial_controller_test.go index df1756ed194..7699c81e537 100644 --- a/pkg/controller/v1alpha2/trial/trial_controller_test.go +++ b/pkg/controller/v1alpha2/trial/trial_controller_test.go @@ -71,12 +71,6 @@ func TestCreateTFJobTrial(t *testing.T) { stopMgr, mgrStopped := StartTestManager(mgr, g) - stopCh := make(chan struct{}) - g.Expect(mgr.GetCache().WaitForCacheSync(stopCh)).To(gomega.BeTrue()) - defer func() { - close(stopCh) - }() - defer func() { close(stopMgr) mgrStopped.Wait() @@ -132,12 +126,6 @@ func TestReconcileTFJobTrial(t *testing.T) { stopMgr, mgrStopped := StartTestManager(mgr, g) - stopCh := make(chan struct{}) - g.Expect(mgr.GetCache().WaitForCacheSync(stopCh)).To(gomega.BeTrue()) - defer func() { - close(stopCh) - }() - defer func() { close(stopMgr) mgrStopped.Wait() @@ -211,12 +199,6 @@ func TestReconcileCompletedTFJobTrial(t *testing.T) { stopMgr, mgrStopped := StartTestManager(mgr, g) - stopCh := make(chan struct{}) - g.Expect(mgr.GetCache().WaitForCacheSync(stopCh)).To(gomega.BeTrue()) - defer func() { - close(stopCh) - }() - defer func() { close(stopMgr) mgrStopped.Wait() @@ -279,12 +261,6 @@ func TestFailedToCreateTrialInDB(t *testing.T) { stopMgr, mgrStopped := StartTestManager(mgr, g) - stopCh := make(chan struct{}) - g.Expect(mgr.GetCache().WaitForCacheSync(stopCh)).To(gomega.BeTrue()) - defer func() { - close(stopCh) - }() - defer func() { close(stopMgr) mgrStopped.Wait()