Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding WG-Data and their owners #642

Merged
merged 2 commits into from
Jan 12, 2024
Merged

Conversation

rareddy
Copy link
Contributor

@rareddy rareddy commented Jan 12, 2024

Adding Model Registry maintainers to Kubeflow

Signed-off-by: Ramesh Reddy <rareddy@jboss.org>
Copy link

Hi @rareddy. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Comment on lines 1016 to 1025
- andreyvelich
- ckadner
- dhirajsb
- isinyaaa
- lampajr
- rareddy
- rkubis
- tarilabs
- Tomcli
- tonyxrmdavidson
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are all of them required to establish this WG?

  1. If anyone of them has not joined Kubeflow yet, it will break our pipeline. Follow https://github.com/kubeflow/internal-acls?tab=readme-ov-file#joining-kubeflow-github-organization to ask them to join kubeflow org first, or remove them from this list for now.
  2. Some of them seem not needed for model registry project, please only keep the owners of this project here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed, only members of KF are listed now. As other folks join the org will submit another PR to add them

Signed-off-by: Ramesh Reddy <rareddy@jboss.org>
@google-oss-prow google-oss-prow bot added size/XS and removed size/S labels Jan 12, 2024
@zijianjoy
Copy link
Contributor

/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rareddy, zijianjoy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 87b62d0 into kubeflow:master Jan 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants