Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REQUEST: Create <api>: the canonical location of the KubeEdge API definition. #193

Open
wbc6080 opened this issue Mar 14, 2024 · 7 comments

Comments

@wbc6080
Copy link
Contributor

wbc6080 commented Mar 14, 2024

1. Name for new repository:

api

2. Who should have admin access(subproject owners)?

@kevin-wangzefeng
@fisherxu

3. Who should have write access?

@kevin-wangzefeng
@fisherxu
@WillardHu
@Shelley-BaoYue
@wbc6080 for sync codes from kubeedge/kubeedge

4. Who should be listed as approvers and reviewers in OWNERS?

approvers:
@kevin-wangzefeng
@fisherxu
@WillardHu
@Shelley-BaoYue
reviewers:
@kevin-wangzefeng
@fisherxu
@WillardHu
@Shelley-BaoYue
@wbc6080

5. What should the repo description be?

Repository for KubeEdge API, providing KubeEdge standard API definition

6. What SIG does this fall under?

All related SIGs

7. Additional context for request.

This repository provides KubeEdge standard API definitions, such as device crd definition and cloudcore, edgecore configuration. During subsequent development, API changes will still be completed under the original path of the KubeEdge main repository(https://github.com/kubeedge/kubeedge/tree/master/staging/src/github.com/kubeedge), and the changes will be synchronized to the API repository later.

@kevin-wangzefeng
Copy link
Member

Thanks for initiating this.

During subsequent development, API changes will still be completed under the original path of the KubeEdge main repository(kubeedge/kubeedge/staging/src/github.com/kubeedge/api/), and the changes will be synchronized to the API repository later.

Is there a more formal location for this description? This is very important for people who would contribute to API, and release team members to make sure they add corresponding tag here when new releases cut in the main repo.

@wbc6080
Copy link
Contributor Author

wbc6080 commented Mar 15, 2024

It should be located in https://github.com/kubeedge/kubeedge/tree/master/staging/src/github.com/kubeedge, I've updated it in the issue description. In addition, the api files have not been migrated to this directory yet. I will complete the migration as soon as possible.

@WillardHu
Copy link
Contributor

/lgtm

@benjaminhuo
Copy link

/lgtm

@kevin-wangzefeng
Copy link
Member

/lgtm
Thanks

@fisherxu
Copy link
Member

/lgtm

@huanwei
Copy link

huanwei commented Oct 16, 2024

/lgtm
thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants