From a209cd71a1d15991e4e6c1cbc9df302086d176c2 Mon Sep 17 00:00:00 2001 From: Mehedi Hasan Date: Wed, 7 Dec 2022 19:17:25 +0600 Subject: [PATCH] update review changes Signed-off-by: Mehedi Hasan --- .../mysql/autoscaler/compute/cluster/index.md | 96 +------------------ .../mysql/clustering/read-replica/index.md | 2 +- 2 files changed, 5 insertions(+), 93 deletions(-) diff --git a/docs/guides/mysql/autoscaler/compute/cluster/index.md b/docs/guides/mysql/autoscaler/compute/cluster/index.md index 1b19eb351..0cb6700af 100644 --- a/docs/guides/mysql/autoscaler/compute/cluster/index.md +++ b/docs/guides/mysql/autoscaler/compute/cluster/index.md @@ -207,56 +207,7 @@ Metadata: Creation Timestamp: 2022-09-16T11:26:58Z Generation: 1 Managed Fields: - API Version: autoscaling.kubedb.com/v1alpha1 - Fields Type: FieldsV1 - fieldsV1: - f:metadata: - f:annotations: - .: - f:kubectl.kubernetes.io/last-applied-configuration: - f:spec: - .: - f:compute: - .: - f:mysql: - .: - f:containerControlledValues: - f:controlledResources: - f:maxAllowed: - .: - f:cpu: - f:memory: - f:minAllowed: - .: - f:cpu: - f:memory: - f:podLifeTimeThreshold: - f:resourceDiffPercentage: - f:trigger: - f:databaseRef: - .: - f:name: - f:opsRequestOptions: - .: - f:apply: - f:timeout: - Manager: kubectl-client-side-apply - Operation: Update - Time: 2022-09-16T11:26:58Z - API Version: autoscaling.kubedb.com/v1alpha1 - Fields Type: FieldsV1 - fieldsV1: - f:status: - .: - f:checkpoints: - f:conditions: - f:vpas: - Manager: kubedb-autoscaler - Operation: Update - Subresource: status - Time: 2022-09-16T11:27:07Z - Resource Version: 846645 - UID: 44bd46c3-bbc5-4c4a-aff4-00c7f84c6f58 + ... Spec: Compute: MySQL: @@ -387,48 +338,7 @@ Metadata: Creation Timestamp: 2022-09-16T11:27:07Z Generation: 1 Managed Fields: - API Version: ops.kubedb.com/v1alpha1 - Fields Type: FieldsV1 - fieldsV1: - f:metadata: - f:ownerReferences: - .: - k:{"uid":"44bd46c3-bbc5-4c4a-aff4-00c7f84c6f58"}: - f:spec: - .: - f:apply: - f:databaseRef: - .: - f:name: - f:timeout: - f:type: - f:verticalScaling: - .: - f:mysql: - .: - f:limits: - .: - f:cpu: - f:memory: - f:requests: - .: - f:cpu: - f:memory: - Manager: kubedb-autoscaler - Operation: Update - Time: 2022-09-16T11:27:07Z - API Version: ops.kubedb.com/v1alpha1 - Fields Type: FieldsV1 - fieldsV1: - f:status: - .: - f:conditions: - f:observedGeneration: - f:phase: - Manager: kubedb-ops-manager - Operation: Update - Subresource: status - Time: 2022-09-16T11:27:07Z + ... Owner References: API Version: autoscaling.kubedb.com/v1alpha1 Block Owner Deletion: true @@ -534,5 +444,7 @@ To clean up the Kubernetes resources created by this tutorial, run: ```bash kubectl delete mysql -n demo sample-mysql kubectl delete mysqlautoscaler -n demo my-as-compute +kubectl delete mysqlopsrequest -n demo myops-vpa-sample-mysql-z43wc8 +kubectl delete mysqlopsrequest -n demo myops-sample-mysql-6xc1kc kubectl delete ns demo ``` \ No newline at end of file diff --git a/docs/guides/mysql/clustering/read-replica/index.md b/docs/guides/mysql/clustering/read-replica/index.md index cbbbecdaa..bc8a738fe 100644 --- a/docs/guides/mysql/clustering/read-replica/index.md +++ b/docs/guides/mysql/clustering/read-replica/index.md @@ -74,7 +74,7 @@ mysql.kubedb.com/mysql created ``` Here, - - `spec.AllowReadReplicas` defines the types of read replicas that MAY be attached to a MySQL instance and the trusted namespaces where those Read Replica resources MAY be present.You will be able to set namespace `spec.allowReadReplicas.NameSpace` and labels `spec.allowReadReplicas.selector`.For more see [here](https://github.com/kubedb/apimachinery/blob/master/apis/kubedb/v1alpha2/mysql_types.go#L159). + - `spec.AllowReadReplicas` defines the types of read replicas that may be attached to a MySQL instance and the trusted namespaces where those Read Replica resources may be present.You will be able to set namespace `spec.allowReadReplicas.NameSpace` and labels `spec.allowReadReplicas.selector`.For more see [here](https://github.com/kubedb/apimachinery/blob/master/apis/kubedb/v1alpha2/mysql_types.go#L159). - `spec.terminationPolicy` specifies what KubeDB should do when a user try to delete the operation of MySQL CR. *Wipeout* means that the database will be deleted without restrictions. It can also be "Halt", "Delete" and "DoNotTerminate". Learn More about these [HERE](https://kubedb.com/docs/latest/guides/mysql/concepts/database/#specterminationpolicy). Now a MySQL instance in `demo` namespace having the label `kubedb.com/instance_name: ReadReplica` will be able to connect to this database as a read replica