Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builders for kube-runtime reflector #276

Closed
3 tasks
clux opened this issue Jul 19, 2020 · 5 comments
Closed
3 tasks

builders for kube-runtime reflector #276

clux opened this issue Jul 19, 2020 · 5 comments
Assignees
Labels
ergonomics ergonomics of the public interface runtime controller runtime related

Comments

@clux
Copy link
Member

clux commented Jul 19, 2020

Trying to propagate kube-runtime to all external repo actix examples and noticing a few things that should be made better for a smoother experience:

  • users need to import watcher when using reflector (even if they expose the same events and they only use one)
  • users need to import Writer when using reflector (even though they cannot really use it sensibly)

Proposed solutions:

Edit: crossing out a few from feedback.
Edit2: removing ancient comments here, as a long time has passed here.

@clux clux added the runtime controller runtime related label Jul 19, 2020
@clux clux added this to the kubecon-eu-2020 milestone Jul 19, 2020
@nightkr

This comment has been minimized.

@clux

This comment has been minimized.

@clux

This comment has been minimized.

@clux clux removed this from the kubecon-eu-2020 milestone Jul 20, 2020
@clux

This comment has been minimized.

@clux clux changed the title smoothen kube-runtime api builders for kube-runtime watcher + reflector? Jul 23, 2020
@clux clux added this to Kube Roadmap Nov 3, 2021
@clux clux moved this to Backlog in Kube Roadmap Nov 3, 2021
@clux clux self-assigned this Nov 7, 2021
@clux clux moved this from Backlog to In Progress in Kube Roadmap Nov 7, 2021
@clux clux changed the title builders for kube-runtime watcher + reflector? builders for kube-runtime reflector Nov 7, 2021
@clux clux added the ergonomics ergonomics of the public interface label Nov 7, 2021
@clux clux moved this from In Progress to Blocked in Kube Roadmap Nov 20, 2021
@clux
Copy link
Member Author

clux commented May 13, 2022

Managed to get around this with an easier solution in #907 thanks to Teo's ideas on WatchStreamExt.

@clux clux closed this as completed May 13, 2022
Repository owner moved this from Blocked to Done in Kube Roadmap May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ergonomics ergonomics of the public interface runtime controller runtime related
Projects
Status: Done
Development

No branches or pull requests

2 participants