runtime metric horrible idea #1533
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kind of horrible test impl - creates a mutex struct and threads it into the controller - forks off substructs into relevant bits which self-update no change - used in scheduler to update queue length Signed-off-by: clux <sszynrae@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1533 +/- ##
=======================================
- Coverage 75.2% 75.1% -0.0%
=======================================
Files 78 79 +1
Lines 6989 7006 +17
=======================================
+ Hits 5249 5258 +9
- Misses 1740 1748 +8
|
|
wondering if this would be better if we actually integrated with a metrics library in a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kind of horrible test impl that i'm stashing here as a warning
Metricsstruct embedding rwlocks struct and threads it into theControllervia its config...it technically works for a PoC:
but this is a horrible setup, because you'd need to update the struct everywhere you change anything (if you want it to capture more than one variable) and it makes everything very ugly. just wanted to see how hacky this would be. looking for better ideas.