Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store GLM-PCA factors as LinearEmbeddingMatrix in SingleCellExperiment #3

Open
willtownes opened this issue Feb 20, 2020 · 2 comments
Assignees

Comments

@willtownes
Copy link
Collaborator

As a user I can apply dimension reduction to a SingleCellExperiment object and access both the factors and the loadings from a LinearEmbeddingMatrix in the reducedDims slot.

  • Verify the factors matrix U is stored properly
  • Verify the loadings matrix V is stored properly
  • Verify there is not an implication in the SingleCellExperiment documentation that UV is supposed to be the mean of the data.
  • Make clear in the documentation that UV is not a predicted mean of the data.
@willtownes willtownes self-assigned this Feb 20, 2020
@willtownes
Copy link
Collaborator Author

note: the offsets, link function, and any row- or column-wise covariates are all needed to be able to make predictions for the mean of the data. Should these be stored in the metadata of the SingleCellExperiment to facilitate prediction? Should we write a predictGLMPCA method? This would be useful for things like molecular cross-validation where they need to reconstruct a "denoised" version of the original data matrix.

@kstreet13
Copy link
Owner

I think that if we switch to storing GLM-PCA results as a LinearEmbeddingMatrix, then we should try to keep all the output in that object. So the offsets, link function, etc. could be stored in the metadata slot of the LinearEmbeddingMatrix, rather than the metadata slot of the SingleCellExperiment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants