Commits on Jun 29, 2020

1. Fix memory corruption when a compound variable is unset …

   The following set of commands ends with a memory fault under
   certain circumstances because ksh attempts to free memory
   twice, causing memory corruption:
   
   $ testarray=(1 2)
   $ compound testarray
   $ unset testarray
   $ eval testarray=
   
   The fix is to make sure 'np->nvfun' is a valid pointer before
   attempting to free memory in 'put_tree'. This patch is from
   OpenSUSE: https://build.opensuse.org/package/view_file/shells/ksh/ksh93-nvtree-free.dif?expand=1
   
   src/cmd/ksh93/sh/nvtree.c:
   - Do not try to free memory when 'np->nvfun' and 'val'
     are false.
   
   src/cmd/ksh93/tests/comvar.sh:
   - Add a regression test for the double free problem. The
     reproducer must be run from an executable script
     with 'ksh -c'.

   

   JohnoKing committed Jun 29, 2020
   Configuration menu

   • View commit details
   • Copy full SHA for ad11740
   • Browse repository at this point

   Copy the full SHA

   ad11740 View commit details

   Browse the repository at this point in the history