diff --git a/src/cmd/ksh93/include/jobs.h b/src/cmd/ksh93/include/jobs.h index 90d9d2f8c7a2..ddd169b63b64 100644 --- a/src/cmd/ksh93/include/jobs.h +++ b/src/cmd/ksh93/include/jobs.h @@ -33,6 +33,7 @@ # include #endif /* !SIGINT */ #include "FEATURE/options" +#include #undef JOBS #if defined(SIGCLD) && !defined(SIGCHLD) @@ -125,16 +126,13 @@ extern struct jobs job; #define vmbusy() 0 #endif -#define job_lock() (job.in_critical++) +#define job_lock() asoincint(&job.in_critical) #define job_unlock() \ do { \ - int sig; \ - if (!--job.in_critical && (sig = job.savesig)) \ - { \ - if (!job.in_critical++ && !vmbusy()) \ - job_reap(sig); \ - job.in_critical--; \ - } \ + int _sig; \ + if (asogetint(&job.in_critical) == 1 && (_sig = job.savesig) && !vmbusy()) \ + job_reap(_sig); \ + asodecint(&job.in_critical); \ } while(0) extern const char e_jobusage[]; diff --git a/src/cmd/ksh93/sh/jobs.c b/src/cmd/ksh93/sh/jobs.c index 9b5348c4b602..6952b9d710ea 100644 --- a/src/cmd/ksh93/sh/jobs.c +++ b/src/cmd/ksh93/sh/jobs.c @@ -1882,14 +1882,8 @@ static int job_chksave(register pid_t pid) void *job_subsave(void) { - /* - * We must make a lock first before doing anything else, - * otherwise GCC will remove the job locking mechanism - * as a result of compiler optimization. - */ - job_lock(); - struct back_save *bp = new_of(struct back_save,0); + job_lock(); *bp = bck; bp->prev = bck.prev; bck.count = 0;