Minify imports and exports #7431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… proper place [ci skip]
…ly worked with the hack we removed
dschuff
approved these changes
Nov 1, 2018
… with the llvm wasm backend
… minify-imports-and-exports
sbc100
approved these changes
Nov 2, 2018
| # get the mapping | ||
| SEP = ' => ' | ||
| mapping = {} | ||
| for line in out.split('\n'): |
| "emscripten_memcpy_big": _emscripten_memcpy_big, | ||
| "c": ___syscall54, | ||
| "d": ___syscall140, | ||
| "a": ___syscall146 |
There was a problem hiding this comment.
Is there meant to be two a keys here? I see that's in the mapping below, but it would probably be clearer to have non-overwritten keys even just for the test?
There was a problem hiding this comment.
Thanks @curiousdannii, that wasn't intentional, I combined two testcases improperly. Fixing.
97 tasks
Beuc
pushed a commit
to Beuc/emscripten
that referenced
this pull request
Nov 17, 2018
For background see emscripten-core#7414 This uses a new binaryen pass WebAssembly/binaryen#1719 to minify the import and export names in wasm, and then updates them in JS too. These are things that closure and other minfiers cannot minify themselves since they are on the js/wasm boundary, so it's up to us. This is kind of related to metadce, which also optimizes stuff on that js/wasm boundary. metadce finds things that can be removed entirely, while this new operation minifies the names of what remains. Turns out this is pretty useful, if you have lots of imports or exports. On BananaBread there are lots of GL calls, and we save 10% of JS size and 1% of wasm size. On Bullet we wrap classes for JS, which means calls to lots of functions, and we save 16% of JS size and 8% of wasm size. Much more than I expected! Some other minor fixes in this PR: * The emterpreter had some hacky way to add the extra globals it needs. Moved those to the proper place. This did require disabling a tiny part of the current test for the emterpreter (asm.js validation of raw emterpreter output, before integration back into the emscripten output), but that's not that important now - it was more useful when bringing it up initially. * Fix embind usage of dynamic dyncalls - they are on the Module object, we should not access Module.asm directly. * For CI testing this uses a temp tag in the binaryen port. Before landing we should tag binaryen and update that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For background see #7414
This uses a new binaryen pass WebAssembly/binaryen#1719 to minify the import and export names in wasm, and then updates them in JS too. These are things that closure and other minfiers cannot minify themselves since they are on the js/wasm boundary, so it's up to us.
This is kind of related to metadce, which also optimizes stuff on that js/wasm boundary. metadce finds things that can be removed entirely, while this new operation minifies the names of what remains.
Turns out this is pretty useful, if you have lots of imports or exports. On BananaBread there are lots of GL calls, and we save 10% of JS size and 1% of wasm size. On Bullet we wrap classes for JS, which means calls to lots of functions, and we save 16% of JS size and 8% of wasm size. Much more than I expected!
Some other minor fixes in this PR:
Module.asmdirectly.For CI testing this uses a temp tag in the binaryen port. Before landing we should tag binaryen and update that.