Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heads up! "webpack-assets-manifest" v3.0.0 has a breaking change #1588

Closed
rodeyseijkens opened this issue Mar 28, 2018 · 4 comments
Closed

Comments

@rodeyseijkens
Copy link

customize: (key, value) => {

Starting from version 3.0.0 webpack-assets-manifest has a breaking change.

Needs to change to:

customize: ({key, value}) => {
...

See version change example

function arguments change to this now: entry, original, manifest, asset

@langpavel
Copy link
Collaborator

Nice, thanks, will check later today or tomorrow, please ping me if I forget,I need fix this soon

@langpavel
Copy link
Collaborator

Looks like only needed change is what you already figure out :-)
I'm quite busy, would you like prepare PR against master ?

@rodeyseijkens
Copy link
Author

@langpavel Will do when I have time too :P

@langpavel
Copy link
Collaborator

I hope this can be closed 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants