-
-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Undisclosed dependency on guzzlehttp/psr:^2.0 #842
Comments
You're right that it's better to not use transitive dependencies and require them in the However, the Could you replace the contents of your If |
I will do this in the upcoming 8.0 release. |
Yes, Because I have another dependency that has pegged |
Ah, got it! Thanks for the clarification, I will do it in a new 7.x release then! |
Implemented in c9f7ef5 and released with https://github.com/kreait/firebase-php/releases/tag/7.7.0 Thanks again! |
Describe the bug
While upgrading a project to Laravel 10, I ran into what I think is an undocumented dependency.
src/Firebase/Factory.php
usesGuzzleHttp\Psr7\HttpFactory
, but that doesn't appear to be a part of the "guzzlehttp/guzzlepackage (which is listed in
composer.json) and is instead a part of
guzzlehttp/psr7` (from v2.x upward).I ran into the issue because I have another dependency that currently hard-depends on
guzzlehttp/psr7:1.6
which silently preventedguzzlehttp/psr7:2.x
from being installed. While the upgrade 'succeeded', my Laravel notifications then failed because of the missingHttpFactory
class.If my understanding is right, then this is simply a matter of listing
guzzlehttp/psr7:^2.0
incomposer.json
for this project. That won't solve my current dependency conflict with the other package, but at least it would have flagged it as a problem earlier in the upgrade process.Installed packages
PHP version and extensions
Steps to reproduce the issue.
(see above)
Error message/Stack trace
Additional information
No response
The text was updated successfully, but these errors were encountered: