Windowed notebook does not update window on panel resize #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Bump @babel/traverse from 7.21.2 to 7.23.2 Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.21.2 to 7.23.2. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse) --- updated-dependencies: - dependency-name: "@babel/traverse" dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> * Fix integrity --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Frédéric Collonval <fcollonval@gmail.com>
* initial work to add kernel history on noteobok * debugging * debugging * rotating through history now * Is working filtering by current kernel * return whole ipython history instead of just the ipython history for given session * cleanup * revert yarn.lock * cleanup * change accessLastHistory to accessPreviousHistory * remove commented out code Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com> * remove console.log Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com> * command updates * move commands * Update packages/notebook/src/history.ts Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com> * add trans to history commandid labels * clean up comments * make back and next return strings, remove accessPrevious and accessNext from widget * make accessHistory commands async, reset history session on retrieval * add history test * working on history * add working test * Add documentation for kernel history iteration * increase wait time in test for reliability * Automatic application of license header * Adds warning to catch failed history retrievals * Allow kernel history to be optional * remove onExecuted * update test to enable history setting * add note about enabling feature in docs * collect history in batches * Update packages/notebook/src/widget.ts Co-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com> * Update packages/notebook/src/history.ts Co-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com> * Update packages/notebook/src/history.ts Co-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com> * Update packages/notebook/src/history.ts Co-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com> * Update packages/notebook/src/widget.ts Co-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com> * Update packages/notebook/src/history.ts Co-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com> * make _history public and readonly * make fetchBatch private, add test * eslint:typed * await back * Update Playwright Snapshots * Update Playwright Snapshots * working jest test * Update packages/notebook/src/history.ts Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com> * Update packages/notebook/src/history.ts Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com> * Update packages/notebook/src/history.ts Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com> * Update packages/notebook/src/history.ts Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com> * Update packages/notebook-extension/schema/tracker.json Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com> * Update docs/source/user/notebook.rst Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com> * Update packages/notebook/src/history.ts Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com> * Update packages/notebook/src/history.ts Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com> * Update packages/notebook/src/history.ts Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com> * Update packages/notebook/src/history.ts Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com> * Update packages/notebook/src/history.ts Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com> * precommit * history -> kernelHistory * add test with no history * add comment for back and forward on content * added forward to test as well * Fix option name (`kernelHistory`) --------- Co-authored-by: Eric Charles <eric@datalayer.io> Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com>
* Added css for consistent underline and colour on links * Added css variable to light theme * Add old CSS property as fallback --------- Co-authored-by: EC2 Default User <m158261@users.noreply.github.com> Co-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com>
* Fix rulers position with gutter width * Add integration test
Remove doc warning
* update to mermaid 10.6.0, marked 9.1.2 * update rjsf to 5.13.2 * disable custom keyboard navigation JS in docs html theme * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Remove doc config --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com>
* Fix auto-closing bracket deletion * Add highlight special characters
* Add support for HTTP proxy * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * format next filter * add httpx support * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * remove space * add httpx dependency * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update jupyterlab/extensions/pypi.py Co-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com> * Update jupyterlab/extensions/pypi.py Co-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com> * Update jupyterlab/extensions/pypi.py Co-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com> * Update jupyterlab/extensions/pypi.py Co-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com> * Update jupyterlab/extensions/pypi.py Co-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com> * Update jupyterlab/extensions/pypi.py Co-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com> --------- Co-authored-by: Dolev Farhi <dfarhi@paloaltonetworks.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com> Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
* Expand search box horizontally when text grows long * Update Playwright Snapshots * Fix button positioning by adjusting padding the top/bottom padding was inflating the input box resulting in the input having over 20px; because it was defined with em it was difficult to adjust for it this change should ensure that with standard font-sizes the buttons will be centered * Update Playwright Snapshots * Revert incorrect snapshot update --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: krassowski <5832902+krassowski@users.noreply.github.com>
* Initial work on ensuring the active cell is always rendered * Scroll to the active cell on `keydown` if out of view * Document and move implementation to private methods, also collapse padding to ensure bounding box is 0. * Add browser tests, update existing tests * Extend the scroll test to markdown cells * Preserve active cell for all types of cells * Fix focus for soft-hidden code cells * Move logic around to actually detach non-active markdown cells * Do not re-attach if cell was soft-hidden So this was caught by tests: if a markdown cell a heading the logic in `showEditor()` would move cursor to the heading start; while that logic maybe should be improved, in this case the problem was that we went ahead with attaching already attached cell; this commit corrects it. * Simplify the scroll test to allow soft-hidden cells The cells which are soft hidden will be interpreted as in `hidden` state by playwright, but won't have a falsy bounding box. The second set of assertions using falsy/truthy bbox is thus not good for soft- hidden cells, and since it is redundant it gets dropped.
* Early WIP for inline completion provider API * Improve ghost text behaviour, widget, and tokens * Improve inline completer hoverbox widget * Implement accept and invoke * Fix shortcuts assignment * Split up ghost to separate file, improve ghost and widget * Improve appending and filter text logic, move protected method * Add `readonly` keyword to identifier/name Co-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com> * Remove `Omit<>`, improve documentation * Expose provider ID on the ghost text widget This is based on the observation that various providers have different ways of styling the ghost text, for example by adding brand-specific background; to enable providers to style the ghost text specifically this commit adds a data attribute on the ghost text widget. * Avoid using `Omit<>` for factory, add readonly on `completions` * Check for items (fix for no kernel) * Add provider icon * Implement settings, rearrange plugins * Make `inlineProviders` optional in options for backward compatibility * Use search history request with limit of 100 cells * Add icons to settings * Polish completer widget icon * Implement settings for inline completion providers * Initial streaming implementation * Implement streaming indicator, typing and streaming animations * Implement setting for streaming animation * Expose mime type in request * Fix hiding stream on cell change & not showing if 1st provider yields empty * Wrap lines (while preserving indentation), useful in markdown * Revert pre-wrap as it introduces jitter on streaming * Better blur handling * Hide inline completions on cursor movement * Implement on hover display of widget * Show new line immediately when streaming * Implement per-provider timeout and debouncer * Restore `pre-wrap`, but exclude the streaming token itself * Integrity fix * Fix invoke command * Add unit tests for inline compelter * Implement progress bar for multiple providers * Automatic application of license header * Remove `const` as `enum const` breaks building tests separately Though ideally it would be `enum cosnt` * Fix initial defaults composition for providers * `onHover`: allow clicking past widget when hidden * Add visual/integration tests * Use `oneOf` instead of `enum` to enable translations * Update Playwright Snapshots * Add missing `await` * Add user-facing and developer-facing docs * Remove LSP provider declaration for now Co-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com> * Fix icon styling in dark theme --------- Co-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Bumps [altair](https://github.com/altair-viz/altair) from 5.1.1 to 5.1.2. - [Release notes](https://github.com/altair-viz/altair/releases) - [Commits](vega/altair@v5.1.1...v5.1.2) --- updated-dependencies: - dependency-name: altair dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [scipy](https://github.com/scipy/scipy) from 1.11.1 to 1.11.3. - [Release notes](https://github.com/scipy/scipy/releases) - [Commits](scipy/scipy@v1.11.1...v1.11.3) --- updated-dependencies: - dependency-name: scipy dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [ipywidgets](https://github.com/jupyter-widgets/ipywidgets) from 8.1.0 to 8.1.1. - [Release notes](https://github.com/jupyter-widgets/ipywidgets/releases) - [Commits](jupyter-widgets/ipywidgets@8.1.0...8.1.1) --- updated-dependencies: - dependency-name: ipywidgets dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [black[jupyter]](https://github.com/psf/black) from 23.7.0 to 23.10.1. - [Release notes](https://github.com/psf/black/releases) - [Changelog](https://github.com/psf/black/blob/main/CHANGES.md) - [Commits](psf/black@23.7.0...23.10.1) --- updated-dependencies: - dependency-name: black[jupyter] dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [pandas](https://github.com/pandas-dev/pandas) from 2.1.1 to 2.1.2. - [Release notes](https://github.com/pandas-dev/pandas/releases) - [Commits](pandas-dev/pandas@v2.1.1...v2.1.2) --- updated-dependencies: - dependency-name: pandas dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…5168) * fix(filebrowser-extension): copy absolute path with first slash * fix(filebrowser-extension): copy absolute path with first slash * Fix typo --------- Co-authored-by: foo <foo@bar.com> Co-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com>
…14529) * adding initial min width to resized side by side cell * adding resize handler to hide/display active cell toolbar dynamically --------- Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
…upyterlab#15282) * add defaultPath option * add tests for defaultPath option * Fixed floating promise There was a floating promise in createFilteredFileBrowser as a result of calling model.cd(). To fix the floating promise, createdFilteredFileBrowser is async and respective changes propagated to places it was used. * Pass the error reason * Lint --------- Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
) * added test for dynamic text spacing for launcher cards * Changed launcher test to galata test folder * added snapshot capability * changes to get min-height value in css * uncomment change * removed min-height * added loop to element.evaluate * changed toBE to toContain * took out loop and added toHaveCSS * used parseFloat * changed to parseInt * made changes to compare recieved to expected value * made some changes * Converting value to string * added px to show on expected value * minor changes * Minor changes * added plus sign * Mad minor changes * changed location of px * changes made to add px * took out comment * Update Playwright Snapshots * Update Playwright Snapshots * changes made to select launcher content instead of label * Update Playwright Snapshots * Update Playwright Snapshots * changes made from feedback * Update Playwright Snapshots * Update Playwright Snapshots --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* BROKEN first pass at overriding ellipses logic * cleaning up click handler for full path * cleaning up comments and const vars * fixing destination typo * adding setting for toggling full path * fixing config name * adding full path to settings schema * moving and adding comments on new set/get method for full path * Add a unit test for new crumbs option --------- Co-authored-by: Stephanie Stattel <stephaniestattel@Stephanies-MacBook-Air.local> Co-authored-by: krassowski <5832902+krassowski@users.noreply.github.com>
github-actions
bot
added
documentation
github-actions
bot
added
pkg:rendermime
pkg:notebook
tag:Testing
pkg:cells
pkg:celltags
pkg:codemirror
pkg:completer
pkg:coreutils
pkg:documentsearch
pkg:extensionmanager
pkg:filebrowser
pkg:help
pkg:lsp
pkg:settingeditor
pkg:settingregistry
pkg:shortcuts
pkg:themes
pkg:ui-components
labels
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Code changes
User-facing changes
Backwards-incompatible changes