-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(TypeScript): Add the workflow file for CI check #1280
Conversation
Hi, I added a bug to test the workflow but it still reported success. |
codes/typescript/chapter_computational_complexity/space_complexity.ts
Outdated
Show resolved
Hide resolved
It seems like executing TypeScript code ( |
Please remove the file changes irrelevant to the CI check to make the semantic of the PR clear. |
By the way, could you avoid unnecessary force-pushes? It's relatively inconvenient to track the history. |
Due to the use of modern ES modules, Node does not yet support https://docs.deno.com/runtime/manual/runtime/import_meta_api#importmetamain require.main === module
// ->
import.meta.url === `file://${process.argv[1]}`
// ->
import esMain from 'es-main';
esMain(import.meta)
|
Co-authored-by: Yudong Jin <krahets@163.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Would you like to add the Javascript's workflow file in a new PR?
In JavaScript, only the previously written |
@Shyam-Chen We can do that for JavaScript because it is a relative Ioose programming language. It's acceptable to only find the exception that crashes the program. (Just like Python) |
If this pull request (PR) pertains to Chinese-to-English translation, please confirm that you have read the contribution guidelines and complete the checklist below:
If this pull request (PR) is associated with coding or code transpilation, please attach the relevant console outputs to the PR and complete the following checklist: